[Bug] Fixes Playback mode timestamps displayed#3142
Merged
clayandgen merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
==========================================
- Coverage 78.26% 78.24% -0.02%
==========================================
Files 673 673
Lines 55239 55239
Branches 728 728
==========================================
- Hits 43232 43222 -10
- Misses 11929 11939 +10
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally correct — when the playback code was written (commit fc4cc2d), the TSDB returned ISO date strings like "2025-07-29T16:08:10.000Z", and new Date(string) parsed those fine. Later, the QuestDB client was refactored (commit 525491c) to return numeric seconds instead.
Some simplification added as well as there were branches that did the same thing now.